Open
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
jona159
changed the title
zven
reviewed
Mar 9, 2026
| {new Date(transferExpiresAt).toLocaleString()} | ||
| </b> | ||
| </p> | ||
| ) : null} |
Member
There was a problem hiding this comment.
- Translations are missing here. Or are those only error messages? We could stick to English, then.
- More important: Once a transfer token is created after clicking on
I understand, transfer this device., it is copied to my clipboard. If I click the button again, the token not shown anymore and there is no way of retrieving it. I also can't create a new one and only get the error messageTransfer already exists for this device. Result: I can never re-create a transfer token as long as an old one is valid.
zven
reviewed
Mar 9, 2026
| return data<ActionData>( | ||
| { | ||
| success: true, | ||
| message: 'Box successfully prepared for transfer', |
Member
There was a problem hiding this comment.
Didn't we want to replace the term box with device?
zven
reviewed
Mar 9, 2026
| ns="device-transfer" | ||
| values={{ deviceName }} | ||
| components={{ b: <b /> }} | ||
| /> |
Member
There was a problem hiding this comment.
Don't we already have the same text and information above? Duplicate!
zven
reviewed
Mar 9, 2026
app/routes/profile.$username.tsx
Outdated
| <input | ||
| name="token" | ||
| type="text" | ||
| placeholder="Transfer-Token eingeben" |
zven
reviewed
Mar 9, 2026
| <div className="mt-3 rounded-md border border-green-200 bg-green-50 px-3 py-2 text-sm text-green-700"> | ||
| {actionData.message ?? t('device_successfully_claimed')} | ||
| </div> | ||
| ) : null} |
Member
There was a problem hiding this comment.
How about putting the "Gerät übernehmen" box below the devices table?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Implementation
Checklist
devbranchAdditional Information